-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps webdriverio
and vulnerable dependencies elliptic
, ws
, and express
#67
Conversation
I'm seeing increased incidence of |
Apparently still not fixed: webdriverio/webdriverio#13553 (comment) |
@romainmenke Do you have any idea what's going on with the BrowserStack test failures? I see a mix of error messages in different steps. Do you think we should give up on the |
This seems problematic and something that should be configurable for our use case: https://github.com/webdriverio/webdriverio/blob/74346f930b035a475733748974dcec8893c08865/packages/webdriverio/src/index.ts#L86-L90 Webdriver should not be applying their own polyfills as that makes it impossible for us to test polyfills. So I think we should reach out and try to resolve those issues. I will try to do a run with those things manually disabled and check if tests start to pass. |
It looks like we can skip polyfills by not using BiDi: https://github.com/webdriverio/webdriverio/blob/74346f930b035a475733748974dcec8893c08865/packages/webdriverio/src/polyfill.ts#L33 I will try that. |
I am also opening an issue with |
Here's a PR against |
elliptic
, ws
, and express
webdriverio
and vulnerable dependencies elliptic
, ws
, and express
@romainmenke This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for working on this 🙇
This PR resolves
npm audit
findings forelliptic
,ws
, andexpress
. As part of this, it bumpswebdriverio
from v8 to v9, which requires some minor configuration changes.