Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds build-types to watch script #83

Merged
merged 3 commits into from
Nov 18, 2024
Merged

Adds build-types to watch script #83

merged 3 commits into from
Nov 18, 2024

Conversation

mhassan1
Copy link
Collaborator

This PR adds the build-types script to the watch script, since tasks/clean is currently deleting the types files without re-generating them.

It also moves the build-types script to come before tasks/buildsources in the build script, purely for consistency with the watch script.

romainmenke
romainmenke approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@romainmenke romainmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM 👍

@mhassan1 mhassan1 enabled auto-merge (squash) November 18, 2024 18:08
@mhassan1 mhassan1 merged commit d42b580 into main Nov 18, 2024
17 checks passed
@mhassan1 mhassan1 deleted the watch-build-types branch November 18, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romainmenke romainmenke romainmenke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhassan1 @romainmenke