Avoid a direct dependency on build_const #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See rust-lang/cargo#4866 for explanation.
|
lgtm if this is what it takes |
|
@whitequark do you think of a test for nostd support so that we don't regress in the future? |
|
@mrhooray I don't think this test can be written without a custom rustc sysroot. In fact, nostd works right now, but only on targets with std; it's not that nostd is broken completely in crc-rs, it's more subtle. |
|
This looks good. I think it is a probably a good idea to avoid a direct dependency. I only added it for convienience in the first place and it does almost the exact same thing. That bug is a pretty interesting one. Makes |
|
sorry about breaking nostd @whitequark, and thanks for fixing! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See rust-lang/cargo#4866 for explanation.