Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues to enable XSendfile #283

Closed
jvies opened this issue Sep 22, 2022 · 4 comments
Closed

Issues to enable XSendfile #283

jvies opened this issue Sep 22, 2022 · 4 comments
Labels

Comments

@jvies
Copy link
Contributor

jvies commented Sep 22, 2022

Hi,

I'd like to enable the XSendfile on my humhub installation (cf https://docs.humhub.org/docs/admin/performance).
In order to not override the while nginx.conf included within the Docker image, it would be great if this file contained a directive include /etc/nginx/conf.d/*.conf; so we can provide additional nginx directives.

Is this OK for you ?
I you want I can try it locally (also to check it still work if /etc/nginx/conf.d is empty), and provide a PR.

Best regards,

@mriedmann
Copy link
Owner

Fine with me. Just issue a PR, will review and merge this. 😊

@jvies
Copy link
Contributor Author

jvies commented Sep 28, 2022

PR is here:
#285

@github-actions
Copy link

This issue is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jun 22, 2023
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

This issue was closed because it has been inactive for 14 days since being marked as stale.

@github-actions github-actions bot closed this as completed Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants