-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow nginx configuration extension through /etc/nginx/conf.d/*.conf #285
Conversation
OK... I think I pushed too quickly :) I'll do some other tests |
3b0acfe
to
17dcc05
Compare
My local test runs fine. As far as I understand, the test that fails checks a button with "Sign in" is present. On my local deployment, this button does not exist, as the page displayed is the installer wizard. |
In theory the test step should start the auto-installer. Maybe you haven't called that locally? Also it could be that it is simply broken. |
210aa7f
to
c3e6886
Compare
I built the docker image locally (using
This happens on master, as on my own branch. Any idea why ? |
c3e6886
to
d7b016f
Compare
d7b016f
to
b22c82e
Compare
fa6394a
to
52f2a3d
Compare
7cec851
to
61c717e
Compare
closed/reopened to run the checks again => There is no apparent reason this is failing. I am a bit puzzled tbh. |
ok, this makes more sense now ... we most likely have to clear out the /etc/nginx/conf.d directory in the nginx base-image. Currently, we are ignoring those files but with your change this will mess up our config. @jvies Can you try to add a "RUN rm -rf /etc/nginx/conf.d" before the copy step in on the nginx image in the Dockerfile? This should fix the pipeline. Will merge it if it runs green. |
61c717e
to
9da69c5
Compare
I might made an error sorry ... deleting the dir might not be what we wanted ... rather deleting the content of it sorry |
9da69c5
to
9810b4f
Compare
seems better thx ! |
9810b4f
to
111afd5
Compare
As of PHP8 under Alpine `/usr/bin/php` does not exist anymore in order to allow co-existence with `php7` packages. The composer therefore fails when trying to execute `php`. Weirdly this issue first surfaced with PR mriedmann#285 but not earlier - not sure why. See https://gitlab.alpinelinux.org/alpine/aports/-/issues/12308
No description provided.