Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugs in file listing #241

Closed
hiltonjanfield opened this issue Jul 23, 2022 · 10 comments
Closed

Bugs in file listing #241

hiltonjanfield opened this issue Jul 23, 2022 · 10 comments
Labels
bug: Confirmed Something isn't working, the bug was confirmed.

Comments

@hiltonjanfield
Copy link

hiltonjanfield commented Jul 23, 2022 •
edited
Loading

In the Print file listing, there is a strange bug using the latest firmware (20220716). Two bugs, technically.

The file list shows a directory entry for .. (previous directory) which I do not recall seeing in the previous firmware version. This is separate from the normal Back entry at the top of the list.

When moving the cursor up from the .. entry to the Back entry, the title of the entry changes to the DOS filename of the first file in the list. For example, if the first file in list is cube_24m_0.20mm_..., the (..) entry will change to CUBE_2~1. This reverts when moving the cursor down from this entry to the first file in the list.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Print'
  2. Go into any subdirectory
  3. See '..' entry
  4. Move cursor up and down past this entry.

Expected behavior
The unnecessary entry appears, and its title changes as described above.

Video

Firmware Version: Ender3S1-F1-UBL-20220716.bin
@mriscoc
Copy link
Owner

mriscoc commented Jul 25, 2022

I received this report before, but I was unable to reproduce it. Maybe you could try to minimize the amount of files in the memory card where this error occurs, then zip the content and post it here.

@hiltonjanfield
Copy link
Author

With a little testing, I found that it only occurs with excessively long filenames, such as those output by PrusaSlicer.
The attached ZIP contains a single directory and a single tiny file. Having just this on a freshly FAT32-formatted SD card will cause the bug for me, when viewing the subdirectory
calibration.zip.

@mriscoc
Copy link
Owner

mriscoc commented Jul 26, 2022

Thank you, I will test it with your file.

@hiltonjanfield
Copy link
Author

hiltonjanfield commented Jul 26, 2022 via email

@mriscoc mriscoc added bug: Confirmed Something isn't working, the bug was confirmed. and removed bug: Potential? labels Aug 5, 2022
@mriscoc
Copy link
Owner

mriscoc commented Aug 5, 2022

I rewrote the select file menu, the next version will have this issue fixed.

@hiltonjanfield
Copy link
Author

I'm glad my information was able to help you sort it out. I might have looked into it myself but I am completely unfamiliar with firmware sources, and was never great with C++. Thank you for all your work in making these machines better! I hope Creality helps you out in some way.

@mriscoc
Copy link
Owner

mriscoc commented Aug 5, 2022

Thanks, I'm not affiliated o related to Creality in any way. It is only the brand of my printer.

mriscoc added a commit that referenced this issue Aug 17, 2022
@mriscoc
20220816 What's new in MID-YEAR Maintenance release I
e35500a 
- Advanced Settings menu reorganization
- Custom G-code C10 to mark a G-code file as a configuration file to avoid confirm to print and print done dialogs.
- Custom G-code C851 Mn ; Set Multiple Probing
- Fix bug: forbid multiple probing = 1
- Custom G-code C851 can be used to change the manual Z-offset for versions without probe
- De-bounce rotary encoder when a parameter is edited
- Allows to set the Z height after Z home for Manual Mesh version.
- Re-enabled ADAPTIVE_STEP_SMOOTHING
- Media Update (auto-mount) Enable/Disable menu item
- Support up to 6 Preheat settings (needs own compile)
- Support for Model predictive temperature control "MPC" (needs own compile)
- Refactoring Print File menu for performance and stability
- Enhanced Active mesh leveling indicator
- Fix drawing bug in select file menu: #241
- Fix: Z at right edge out of mesh border is being overcompensated if UBL is active

From Last Marlin bugfix 2.1.x
- Optimize Planner calculations
- Arc/Planner optimization follow-up
- Update MPCTEMP G-Code M306 T
- Fix, improve Linear Advance with stand-alone stepper driver support
@mriscoc
Copy link
Owner

mriscoc commented Aug 17, 2022

Fixed in the latest version.

@mriscoc mriscoc closed this as completed Aug 17, 2022
mriscoc added a commit that referenced this issue Aug 18, 2022
@mriscoc
20220816 What's new in MID-YEAR Maintenance release I
42410e5 
- Advanced Settings menu reorganization
- Custom G-code C10 to mark a G-code file as a configuration file to avoid confirm to print and print done dialogs.
- Custom G-code C851 Mn ; Set Multiple Probing
- Fix bug: forbid multiple probing = 1
- Custom G-code C851 can be used to change the manual Z-offset for versions without probe
- De-bounce rotary encoder when a parameter is edited
- Allows to set the Z height after Z home for Manual Mesh version.
- Re-enabled ADAPTIVE_STEP_SMOOTHING
- Media Update (auto-mount) Enable/Disable menu item
- Support up to 6 Preheat settings (needs own compile)
- Support for Model predictive temperature control "MPC" (needs own compile)
- Refactoring Print File menu for performance and stability
- Enhanced Active mesh leveling indicator
- Fix drawing bug in select file menu: #241
- Fix: Z at right edge out of mesh border is being overcompensated if UBL is active

From Last Marlin bugfix 2.1.x
- Optimize Planner calculations
- Arc/Planner optimization follow-up
- Update MPCTEMP G-Code M306 T
- Fix, improve Linear Advance with stand-alone stepper driver support
mriscoc added a commit that referenced this issue Aug 21, 2022
@mriscoc
20220821 What's new in MID-YEAR Maintenance release I
cda9310 
- Advanced Settings menu reorganization
- Custom G-code C10 to mark a G-code file as a configuration file to avoid confirm to print and print done dialogs.
- Custom G-code C851 Mn ; Set Multiple Probing
- Fix bug: forbid multiple probing = 1
- Custom G-code C851 can be used to change the manual Z-offset for versions without probe
- De-bounce rotary encoder when a parameter is edited
- Allows to set the Z height after Z home for Manual Mesh version.
- Re-enabled ADAPTIVE_STEP_SMOOTHING
- Media Update (auto-mount) Enable/Disable menu item
- Support up to 6 Preheat settings (needs own compile)
- Support for Model predictive temperature control "MPC" (needs own compile)
- Refactoring Print File menu for performance and stability
- Enhanced Active mesh leveling indicator
- Fix drawing bug in select file menu: #241
- Fix: Z at right edge out of mesh border is being overcompensated if UBL is active
- Preliminary support for Voxelab Aquila printers
@hiltonjanfield
Copy link
Author

hiltonjanfield commented Oct 11, 2022 via email

@mriscoc mriscoc changed the title Bugs in file listing Bugs in file listing with SYNWIT (VIEWE) screen unit Oct 18, 2022
@mriscoc mriscoc changed the title Bugs in file listing with SYNWIT (VIEWE) screen unit Bugs in file listing Oct 18, 2022
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug: Confirmed Something isn't working, the bug was confirmed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mriscoc @hiltonjanfield