-
-
Notifications
You must be signed in to change notification settings - Fork 3
Open
Labels
changes/sourceSource file changesSource file changeskind/featureNew feature or requestNew feature or requestpriority/3Medium priorityMedium prioritystatus/readyReady to workReady to work
Description
Contact Details
Feature Description
Change boolean return/exit values, for full functions, from what they are to returning true or false.
Why?
Inconsistency of return values is a really bad code smell.
What should happen?
This isn't a bug because it works as is, but it is very bad practice.
For entire functions (currently full scripts, later packages), not functions inside of functions boolean return values should return true or false rather than throwing errors, exiting, returning 0or1`, or anything else.
Covers this TODO.
Steps to Test
- Check the return value of every function, if it is boolean it should be returning a
trueorfalse
Code of Conduct
- I agree to follow this project's Code of Conduct
Metadata
Metadata
Assignees
Labels
changes/sourceSource file changesSource file changeskind/featureNew feature or requestNew feature or requestpriority/3Medium priorityMedium prioritystatus/readyReady to workReady to work