-
-
Notifications
You must be signed in to change notification settings - Fork 3
chore: bump version to 0.1.4 and fix code coverage workflow for GitHub Actions updates #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump version to 0.1.4 and fix code coverage workflow for GitHub Actions updates #260
Conversation
Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com>
mrlunchbox777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
@copilot can you fix the code coverage workflow so it doesn't fail on sub-PRs like this? |
…changes Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com>
Fixed in 345db79. Added path filters to the code coverage workflow so it only runs when Go source files, go.mod, go.sum, or the workflow itself changes. This prevents the workflow from running on documentation-only or version-only PRs like this one. |
mrlunchbox777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
942c869
into
dependabot/github_actions/dot-github/workflows/version-updates-4dbe6115e0
… /.github/workflows with 2 updates (#259) * chore: github actions update(deps): bump the version-updates group Bumps the version-updates group in /.github/workflows with 2 updates: [actions/checkout](https://github.com/actions/checkout) and [asdf-vm/actions](https://github.com/asdf-vm/actions). Updates `actions/checkout` from 4 to 6 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v6) Updates `asdf-vm/actions` from 3 to 4 - [Release notes](https://github.com/asdf-vm/actions/releases) - [Changelog](https://github.com/asdf-vm/actions/blob/master/CHANGELOG.md) - [Commits](asdf-vm/actions@v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major dependency-group: version-updates - dependency-name: asdf-vm/actions dependency-version: '4' dependency-type: direct:production update-type: version-update:semver-major dependency-group: version-updates ... Signed-off-by: dependabot[bot] <support@github.com> * chore: bump version to 0.1.4 and fix code coverage workflow for GitHub Actions updates (#260) * Initial plan * chore: bump version to 0.1.4 for GitHub Actions updates Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com> * fix: add path filters to code coverage workflow to skip on docs-only changes Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com> Co-authored-by: Andrew Shoell <mrlunchbox777@gmail.com>
Thanks for contributing!
Background
To pass the semanic-prs check, ensure you prefix your title with one of the
.typesin semanic.yml, followed by a:, e.g.feature: My PRResponse: Dependabot PR #259 - GitHub Actions version updates
Response:
Dependabot updated GitHub Actions dependencies (
actions/checkoutv4→v6,asdf-vm/actionsv3→v4), but thedocs-bumpworkflow requires version and CHANGELOG updates for any PR. Added version bump and CHANGELOG entry to satisfy CI requirements.Additionally, fixed the code coverage workflow to prevent unnecessary runs on documentation-only or version-only PRs by adding path filters.
Changes:
BasicSetupCliVersionfrom0.1.3to0.1.4inbsctl/static/resources/constants.yaml0.1.4documenting the GitHub Actions updates.github/workflows/go-coverage-report.yamlto only trigger on Go source file changes (bsctl/**/*.go), dependency changes (go.mod,go.sum), or workflow file changesResponse:
./bsctl/scripts/workflows/docs-bump_docs-bump_version-bump.sh- should exit 0./bsctl/scripts/workflows/docs-bump_docs-bump_CHANGELOG-bump.sh- should exit 0docs-bumpworkflow passes in CIRequired Checkboxes
All of these checkboxes are required for PR's to be considered.
PR Checks
Code of Conduct
By submitting this PR, you agree to follow our Code of Conduct
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.