-
-
Notifications
You must be signed in to change notification settings - Fork 3
feature: auto-bump version and CHANGELOG for Dependabot PRs with robust validation #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com>
|
Thank you for being part of our community and opening a pull request. We will work with you as soon as possible to integrate your contribution. |
…orkflow Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com>
…LOG formatting Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds automation to handle version bumping and CHANGELOG updates for Dependabot PRs, addressing the issue where Dependabot PRs fail the docs-bump validation workflow.
Changes:
- New GitHub Actions workflow that triggers on Dependabot PR creation
- Shell script to automatically bump the patch version in
constants.yaml - Shell script to extract dependency information and update
CHANGELOG.md
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
.github/workflows/dependabot-autobump.yaml |
New workflow that triggers on Dependabot PR open events, runs version and CHANGELOG update scripts, and commits changes back to the PR |
bsctl/scripts/workflows/dependabot-autobump_bump-version.sh |
Script that parses the current version from constants.yaml, increments the patch version, and writes it back |
bsctl/scripts/workflows/dependabot-autobump_update-changelog.sh |
Script that extracts dependency information from PR title and adds a new CHANGELOG entry with the bumped version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bsctl/scripts/workflows/dependabot-autobump_update-changelog.sh
Outdated
Show resolved
Hide resolved
bsctl/scripts/workflows/dependabot-autobump_update-changelog.sh
Outdated
Show resolved
Hide resolved
bsctl/scripts/workflows/dependabot-autobump_update-changelog.sh
Outdated
Show resolved
Hide resolved
|
@copilot bump the docs and add an AGENTS.md that includes some standards for idiomatic go, bash standards, bumping docs, testing, documentation, and linting using industry standards for all. |
|
@copilot apply changes based on the comments in this thread |
- Improved version validation with semver format checking and numeric validation - Enhanced PR title parsing with regex patterns for better Dependabot title handling - Added idempotency check to prevent duplicate bumps on workflow reruns - Added yq installation step for CI reliability - Improved error handling with trap for temp file cleanup - Created AGENTS.md with comprehensive coding standards for Go, Bash, testing, docs, and linting - Bumped version to 0.1.5 and updated CHANGELOG Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com>
Bumped docs to version 0.1.5 and created AGENTS.md with comprehensive standards for idiomatic Go, Bash practices, documentation, testing, version bumping process, and linting. The document includes industry-standard guidelines with examples and references. See commit 15f7f8e. |
Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com>
All 10 review comments from that thread have already been addressed in commits 15f7f8e and b13a946: ✅ Comprehensive regex patterns for PR title parsing No additional changes needed - all feedback has been implemented. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bsctl/scripts/workflows/dependabot-autobump_update-changelog.sh
Outdated
Show resolved
Hide resolved
|
@copilot apply changes based on the comments in this thread |
- Added set -o pipefail to both bash scripts for robust error handling in pipes - Replaced manual yq download with mikefarah/yq@v4 GitHub Action for secure installation with checksum verification - Quoted GITHUB_OUTPUT variable references following bash best practices Co-authored-by: mrlunchbox777 <9466269+mrlunchbox777@users.noreply.github.com>
Applied all 5 review comments from that thread in commit ca7a72c: ✅ Added All changes follow AGENTS.md standards for bash error handling and security best practices. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mrlunchbox777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Plan: Dependabot Version Bumps Automation ✅
Summary
This PR implements automatic version and CHANGELOG updates for Dependabot PRs with robust error handling, validation, security improvements, and comprehensive documentation.
Latest Improvements (Following AGENTS.md Standards) ✅
Security & Best Practices:
set -o pipefailto both bash scripts (AGENTS.md recommendation)mikefarah/yq@v4GitHub Action (secure, verified)$GITHUB_OUTPUTvariables (bash best practices)All Previous Improvements ✅
Core Functionality:
Documentation:
Version: 0.1.5 with comprehensive CHANGELOG
Files Changed
.github/workflows/dependabot-autobump.yaml- Secure yq installation, quoted variablesbsctl/scripts/workflows/dependabot-autobump_bump-version.sh- Added pipefailbsctl/scripts/workflows/dependabot-autobump_update-changelog.sh- Added pipefailAGENTS.md- Comprehensive coding standardsCHANGELOG.md- Updated to version 0.1.5bsctl/static/resources/constants.yaml- Version 0.1.5Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.