Add test to make sure the detekt default config is correct #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmans0n
commented
Oct 14, 2024
| @@ -11,7 +11,7 @@ Compose: | |||
| active: true | |||
| ContentEmitterReturningValues: | |||
| active: true | |||
| ContentSlotReusedCheck: | |||
| ContentSlotReused: | |||
There was a problem hiding this comment.
Woops, this rule wasn't properly configured -- which means it wasn't enabled by default, and it should have been. The test caught it, and now it's fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There have been some issues with either forgetting to add stuff to the detekt default config, or screwing up the
activevalues (whether they are opt-in or not by default).I've added a test to prevent this from happening again, which will parse the yaml file and assert that all rules are added to it, and that the active value is correct.