Updated to RxJava2 and Implemented Lambdas Where Possible #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you say in the readme this is deprecated, but I thought it was useful and decided to do the legwork to bring the dependencies up to date, especially regarding RxJava2. I updated all of the observables to follow the new API's, and refactored all functional interfaces to instead be lambdas.
I also updated the Activity to use RxJava2, and removed the mapper functionality (this is instead done with Java8 streams, and the app does have an API 24 dependency as a result). If this is a problem, you can always instead just use the streamsupport backport and remove the API requirement.