Merge pull request #336 from Trott/dere

fix: adjust inefficient regular expression
mrmlnc · Jan 2, 2022 · 92b68d9 · 92b68d9
2 parents 2d1b749 + c6c0ca5
commit 92b68d9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/utils/pattern.spec.ts b/src/utils/pattern.spec.ts
@@ -112,6 +112,7 @@ describe('Utils → Pattern', () => {
 
 			it('should return false for unfinished regex character class', () => {
 				assert.ok(!util.isDynamicPattern('['));
+				assert.ok(!util.isDynamicPattern('['.repeat(999999)));
 				assert.ok(!util.isDynamicPattern('[abc'));
 			});
 

diff --git a/src/utils/pattern.ts b/src/utils/pattern.ts
@@ -9,7 +9,7 @@ const GLOBSTAR = '**';
 const ESCAPE_SYMBOL = '\\';
 
 const COMMON_GLOB_SYMBOLS_RE = /[*?]|^!/;
-const REGEX_CHARACTER_CLASS_SYMBOLS_RE = /\[.*]/;
+const REGEX_CHARACTER_CLASS_SYMBOLS_RE = /\[[^[]*]/;
 const REGEX_GROUP_SYMBOLS_RE = /(?:^|[^!*+?@])\(.*\|.*\)/;
 const GLOB_EXTENSION_SYMBOLS_RE = /[!*+?@]\(.*\)/;
 const BRACE_EXPANSIONS_SYMBOLS_RE = /{.*(?:,|\.\.).*}/;