Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix HybridObjectRegistry not being found with JNI in release #316

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: Fix HybridObjectRegistry not being found with JNI in release #316

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44f6cda
fix: Fix `HybridObjectRegistry` not being found with JNI in release
mrousavy Nov 11, 2024
96685da
chore: Rename comment
mrousavy Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ges/react-native-nitro-modules/android/src/main/cpp/registry/JHybridObjectInitializer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// JHybridObjectInitializer.hpp
// DoubleConversion
// react-native-nitro
//
// Created by Marc Rousavy on 22.07.24.
//
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-modules/android/src/main/cpp/registry/JHybridObjectRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// JHybridObjectRegistry.cpp
// DoubleConversion
// react-native-nitro
//
// Created by Marc Rousavy on 22.07.24.
//
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-modules/android/src/main/cpp/registry/JHybridObjectRegistry.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// JHybridObjectRegistry.hpp
// DoubleConversion
// react-native-nitro
//
// Created by Marc Rousavy on 22.07.24.
//
Expand Down
4 changes: 4 additions & 0 deletions ...tive-nitro-modules/android/src/main/java/com/margelo/nitro/core/HybridObjectRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,16 @@
package com.margelo.nitro.core;

import androidx.annotation.Keep;
import com.facebook.proguard.annotations.DoNotStrip;
import com.margelo.nitro.JNIOnLoad;

/**
* A registry that holds initializers for HybridObjects.
* This will be used to initialize them from JS using `NitroModules.createHybridObject<T>(name)`.
* @noinspection JavaJniMissingFunction
*/
@Keep
@DoNotStrip
public class HybridObjectRegistry {
static {
JNIOnLoad.initializeNativeNitro();
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-modules/cpp/registry/HybridObjectRegistry.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// HybridObjectRegistry.cpp
// DoubleConversion
// react-native-nitro
//
// Created by Marc Rousavy on 22.07.24.
//
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-modules/cpp/registry/HybridObjectRegistry.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// HybridObjectRegistry.hpp
// DoubleConversion
// react-native-nitro
//
// Created by Marc Rousavy on 22.07.24.
//
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-modules/ios/turbomodule/NativeNitroModules+NewArch.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// NativeNitroModules+NewArch.mm
// DoubleConversion
// react-native-nitro
//
// Created by Marc Rousavy on 21.06.24.
//
Expand Down
2 changes: 1 addition & 1 deletion packages/react-native-nitro-modules/ios/turbomodule/NativeNitroModules+OldArch.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
//
// NativeNitroModules+OldArch.mm
// DoubleConversion
// react-native-nitro
//
// Created by Marc Rousavy on 21.06.24.
//
Expand Down
Loading