fix: Fix "legacy" enum
s breaking Swift compiler
#346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only tested a string enum (discriminating union):
Now, we also test an "old" enum, aka an enum backed by a number:
This is a slightly different implementation on the native side, since we now use the number as a value of truth.
On iOS, for some reason this breaks when using
std::optional<Enum>
.This code breaks:
This code works:
So this PR fixes this. And adds a test.