Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ios privacy manifest #653

Closed
wants to merge 3 commits into from
Closed

Conversation

RhyG
Copy link

@RhyG RhyG commented Mar 23, 2024

Added a privacy manifest file to comply with Apple's upcoming privacy manifest requirements.

I based the reason and type off of Apple's docs for describing use of required reason API and my understanding of what the library uses, but if it's not quite correct let me know and happy to adjust it.

@RhyG RhyG closed this Mar 24, 2024
@RhyG RhyG reopened this Mar 24, 2024
@jbrodriguez
Copy link

the underlying library maintainer is removing uses of the apis that trigger the warning (he doesn't seem willing to include a privacy manifest in his library)

last change was made 2 days ago, i'm not sure if he cleaned up all instances of "offending" APIs, so it's probably a good idea to still declare the manifest here 🤷‍♂️ ?

any thoughts @RhyG ?

thanks for your work btw 👍

@mrousavy
Copy link
Owner

Hey - thanks for this PR, this is dope!

But I agree with @jbrodriguez - the maintainer of Tencent/MMKV is removing all the APIs that require such privacy manifests, and I think that's a better solution moving forward. See commits like Tencent/MMKV@1feba14

@RhyG
Copy link
Author

RhyG commented Mar 27, 2024

@jbrodriguez @mrousavy fully agree, would rather the permissions gone for sure. That's similar to what react-native-gesture-handler did software-mansion/react-native-gesture-handler#2830

If that lib ends up removing all permissions that means this isn't needed so happy to close this one in favour of that approach 🙂

@RhyG RhyG force-pushed the privacy_manifest branch from f970968 to a959706 Compare March 30, 2024 07:44
@mobileteo
Copy link

Any update on the release of this?

@cjutstraMaxedy
Copy link

@mrousavy Could you check this PR? It's relatively simple. The alternative is that the manifest has to be set on the app level, which is a little dirty IMO.

@mrousavy
Copy link
Owner

@mrousavy Could you check this PR? It's relatively simple. The alternative is that the manifest has to be set on the app level, which is a little dirty IMO.

Again, the real solution to this would be to upgrade the core MMKV library and remove all of the sensitive APIs. You can already do that by just running pod update yourself.

In V3 I've already fixed this.

@cjutstraMaxedy
Copy link

@mrousavy Could you check this PR? It's relatively simple. The alternative is that the manifest has to be set on the app level, which is a little dirty IMO.

Again, the real solution to this would be to upgrade the core MMKV library and remove all of the sensitive APIs. You can already do that by just running pod update yourself.

In V3 I've already fixed this.

My bad, thanks for the reply. I had linked this ticket to track the issue but not realized there was a solution.

@RhyG
Copy link
Author

RhyG commented May 2, 2024

In that case are you happy for me to close this @mrousavy?

@mrousavy
Copy link
Owner

mrousavy commented May 2, 2024

yup thx

@mrousavy mrousavy closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants