fix: Fix NoSuchElementException in getRecommendedBitRate (#2266)

* Remove unused hasConstants method. Do no thrown error on minBy call when filterd videoProfiles contains zero items. * Remove not related to the fix changes.
mrousavy · Dec 12, 2023 · a612eb9 · a612eb9 · vercel · Dec 12, 2023
1 parent 4ee52d6
commit a612eb9
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/...id/src/main/java/com/mrousavy/camera/extensions/RecordingSession+getRecommendedBitRate.kt b/...id/src/main/java/com/mrousavy/camera/extensions/RecordingSession+getRecommendedBitRate.kt
@@ -31,7 +31,7 @@ fun RecordingSession.getRecommendedBitRate(fps: Int, codec: VideoCodec, hdr: Boo
   if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
     val profiles = CamcorderProfile.getAll(cameraId, quality)
     if (profiles != null) {
-      val best = profiles.videoProfiles.filterNotNull().minBy {
+      val best = profiles.videoProfiles.filterNotNull().minByOrNull {
         abs(it.width * it.height - targetResolution.width * targetResolution.height)
       }