fix: RN 0.73 support by solving #2263: Kotlin compilation fails due to "'hasConstants' overrides nothing" at CameraDevicesManager.kt #2264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls due to "'hasConstants' overrides nothing" at CameraDevicesManager.kt
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
LGTM! Tested on Redmi Note 11T 5G
|
5 tasks
|
<@mrousavy> this fixes a problem. |
idrissakhi
approved these changes
Dec 11, 2023
|
Hey - can you please test if this still works in RN 0.72/0.71? I remember that there could be warnings in the console if you don't override this... |
rivaslive
approved these changes
Dec 12, 2023
|
Please you could merge this change? I working in react 0.73.0 @mrousavy |
Hey @mrousavy, 👋 Thank you for reviewing this! I made sure to check for backward compatibility with RN 0.72.7 before raising the PR, and I didn't encounter any problems or build time warnings. |
|
Awesome, thanks for testing man - LGTM! |
isaaccolson
pushed a commit
to isaaccolson/deliveries-mobile
that referenced
this pull request
Oct 30, 2024
…vicesManager.kt (mrousavy#2264) Co-authored-by: Przemysław Arlet <przemyslaw.arlet@lamel.pl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: RN 0.73 support by solving #2263: Kotlin compilation fails due to "'hasConstants' overrides nothing" at CameraDevicesManager.kt