Use cookiejar on Keycloak API requests #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrparkers
approved these changes
Nov 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most likely due to either configuration issues with our cache or a bug in Keycloak itself, we've been seeing 404s immediately after resource creation (mainly with client scope mappers).
This causes the provider to immediately remove the newly-created resource from state, which makes subsequent applies either fail or duplicate resources.
As a temporary workaround we enabled sticky sessions and changed the provider to persist and send cookies. While we'd like to figure this out and remove sticky sessions from our loadbalancer, it also seemed like it might be useful if the provider utilized sticky sessions if they were configured.