Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement keycloak_group data source #185

Merged
merged 5 commits into from
Dec 18, 2019
Merged

Implement keycloak_group data source #185

merged 5 commits into from
Dec 18, 2019

Conversation

madddi
Copy link
Contributor

@madddi madddi commented Dec 11, 2019

No description provided.

@madddi madddi marked this pull request as ready for review December 11, 2019 17:21
mrparkers
mrparkers approved these changes Dec 16, 2019
View reviewed changes
Copy link
Owner

@mrparkers mrparkers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for the PR!

@madddi
Copy link
Contributor Author

madddi commented Dec 18, 2019

Thanks, is there anything preventing a merge? We're currently working with a custom binary and are waiting for a new release 🙂

@mrparkers
Copy link
Owner

My bad, I meant to merge this after tests passed but forgot to. I'll cut a release for you later today 😄

@mrparkers mrparkers merged commit 4a6e449 into mrparkers:master Dec 18, 2019
@madddi madddi deleted the data-source-keycloak-group branch December 19, 2019 13:58
@madddi
Copy link
Contributor Author

madddi commented Dec 19, 2019

Perfect, thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrparkers mrparkers mrparkers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madddi @mrparkers