add cache policy parameter to ldap user federation #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgroschupp
force-pushed
the
feat/add-ldap-cache-policy-parameter
branch
4 times, most recently
from
a1d6c95
to
8bcb857
Compare
|
Hey @cgroschupp, thanks for the PR. These changes look good. What would you think about deprecating the existing cache {
policy = "EVICT_WEEKLY"
eviction_day = 2
eviction_hour = 0
eviction_minute = 0
}If you like this, I can push some changes to your branch to get it implemented, or you could take a stab at it yourself. |
cgroschupp
force-pushed
the
feat/add-ldap-cache-policy-parameter
branch
3 times, most recently
from
ae83c44
to
9b1742b
Compare
cgroschupp
force-pushed
the
feat/add-ldap-cache-policy-parameter
branch
from
9b1742b
to
1f1c4bd
Compare
|
@mrparkers thank you for your feedback. I have deprecated cache_policy and added it to the cache schema. |
|
@mrparkers Is the change ok? |
mrparkers
approved these changes
Sep 18, 2020
hcl31415
pushed a commit
to hcl31415/terraform-provider-keycloak
that referenced
this pull request
Oct 12, 2020
…cate cache_policy (mrparkers#376)
hcl31415
pushed a commit
to hcl31415/terraform-provider-keycloak
that referenced
this pull request
Oct 12, 2020
…cate cache_policy (mrparkers#376)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.