feat: Adding support for login theme on saml_client resource #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diffusedlight
changed the title
mrparkers
requested changes
Sep 8, 2021
There was a problem hiding this comment.
Hey @cw1o, thanks for the PR. This looks good, but we're missing calls to data.Get and data.Set, which is responsible for retrieving the value from your HCL configuration and persisting it back to state, respectively.
You'll want to modify these two functions to add these lines of code:
mapToSamlClientFromData- we should calldata.Getwithin this function to help build thekeycloak.SamlClientto send off to KeycloakmapToDataFromSamlClient- we should calldata.Setwithin this function to persist the value from Keycloak back to Terraform state.
|
I've updated both of them functions now, tests look okay. That 11.0.3 one might need rerunning don't know what happened there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been using the provider for a little while and noticed the SAML Client doesn't support setting the login theme via TF. This should enable that. If there's anything that needs tweaking let me know.