fix: use payload when deleting keycloak_generic_role_mapper for realm roles #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rd-robert-avram
changed the title
mrparkers
approved these changes
Dec 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #771
Everything I've added here is based on what I've seen Keycloak do when performing this action in the UI.
The test itself indirectly catches the misbehaviour described in the issue by failing due to the fact that there's a non-empty intermediate plan occurring during the test case itself. That plan is the creation of the resources that had never actually been explicitly destroyed in the first place.
I hope this is sufficient.