fix: avoid validation errors during plan for missing realm and openid client resources #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kherock
force-pushed
the
fix-missing-default-scope-refresh
branch
from
baae0c3
to
d2ff8f6
Compare
This comment was marked as resolved.
This comment was marked as resolved.
kherock
force-pushed
the
fix-missing-default-scope-refresh
branch
2 times, most recently
from
e18f3cd
to
663f2e2
Compare
|
I was able to restore the original message! Would really appreciate a review on this one |
kherock
force-pushed
the
fix-missing-default-scope-refresh
branch
from
663f2e2
to
735a810
Compare
|
@mrparkers sorry to be a bother, but could this be looked at soon? |
|
Sorry, I meant to get to this before the latest release, but it slipped my mind. This LGTM, I'll merge after tests pass and cut a release today. |
mrparkers
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #738
This brings the 404 handling of missing OpenID clients in line with the implementation for missing SAML clients when resolving client scopes. Basically, the validation of the 404 response was occurring too early, and the read context was throwing instead of return a blank ID via the
handleNotFoundhandler.This also includes a similar fix for
generic_role_mapperresources.The way that I tested these fixes was to configure a realm using these resource types, and run
terraform refreshafter manually deleting the realm.