-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add needed base calls when using FluxorComponent #82
Comments
Yes, that seems like a good idea. If you'd like to submit a PR, I'd be happy to look at it.
|
mrpmorris
added a commit
that referenced
this issue
Aug 25, 2020
mrpmorris
added a commit
that referenced
this issue
Aug 25, 2020
Merged
mrpmorris
added a commit
that referenced
this issue
Aug 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was having some issues when disposing a Component that inherited from FluxorComponent until I realized I didn't call base.OnInitialized when overriding the method. This caused the subscription that is disposed later to be null triggering the exception. I'm creating this issue just to suggest that maybe it would be a good idea to add the remark that a call to base.OnInitialized is needed when using FluxorComponent and overriding OnInitialized.
Great work with the library.
The text was updated successfully, but these errors were encountered: