Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/5.0 #239

Merged
merged 11 commits into from
Jan 13, 2022
Merged

Release/5.0 #239

merged 11 commits into from
Jan 13, 2022

Conversation

mrpmorris
Copy link
Owner

No description provided.

@lucaswalter
Copy link

@mrpmorris Anything else we can do in terms of reviewing & testing here? We are very interested in being able to pull in the fluxor initialization changes.

@rodrigochapeta
Copy link

Hi @mrpmorris,
This looks great, keen on the change to is/ is not operators, look forward to this release

@uhfath
Copy link
Contributor

uhfath commented Dec 24, 2021

This looks promising!
However, one question, @mrpmorris.
Will it be possible to 'select' multiple values in a state selector?
With multiple Select calls or through an anonymous object?

@mrpmorris
Copy link
Owner Author

A state selector will only have a single selector.

@uhfath
Copy link
Contributor

uhfath commented Dec 27, 2021

Thanks. Is there any particular reason for this?

@mrpmorris
Copy link
Owner Author

It's a strongly-typed generic, so it takes <TState, TSubSelectionOfThatState> as generic parameters. So you need one per selection otherwise I'd have to have <TState1, TSelection1, TState2, TSelection2, TState3, TSelection3> along with properties State1, State2, State3 etc.

It quickly becomes unwieldy, and is far simpler to have multiple injected properties in the component instead.

@uhfath
Copy link
Contributor

uhfath commented Dec 29, 2021

It quickly becomes unwieldy, and is far simpler to have multiple injected properties in the component instead.

That's a good point. Thanks for the info.
Looking forward to take a look.

@mrpmorris mrpmorris merged commit 65a96b5 into master Jan 13, 2022
@mrpmorris mrpmorris deleted the release/5.0 branch January 30, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants