Add async overload of SubscribeToAction #533
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
FluxorComponent.SubscribeToAction
to work with mutable objects (such as DTO's), I often need to transition into async code. An example would be where we are binding a DataGrid to a DTO. The 3rd party components methods for refreshing are asynchronous.In this scenario, it would really useful to have an async variant for the
SubscribeToAction
method, replacing theAction<TAction> callback
parameter withFunc<TAction, Task> callback
and then awaiting this inside ofInvokeAsync
. This avoidsStateHasChanged
being called before the handler has fully completed.In my own project, I have a custom version of FluxorComponent where we have implemented this and it is working well. I wanted to suggest adding this to the base component.