Add random laplace number and div_or_else function #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On branch feature/random-fenerators Changes to be committed: new file: quinn/math.py
On branch feature/random-fenerators Changes to be committed: modified: quinn/math.py
jeffbrennan
reviewed
Nov 22, 2023
|
@jeffbrennan I went though the issue and see that we discussed that this part will be used like |
|
Yeah looks good then. Thanks for checking that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On branch feature/random-fenerators
Changes to be committed:
new file: quinn/math.py
Related to #88
I have no idea how to test generation of random numbers without installing
numpy. But I made few local tests and looks like it works.There is the result of
rand_laplace(mu=-5, beta=4):There is the result of
rand_laplace(mu=1, beta=2):And there is how it should look like based on Wiki:
One can see that distribution is correct. Also negative mu is processed correctly too.