Properly escape release attachment URL

Make sure file attachments on a release get a properly escaped URL when linking. Fixes go-gitea#6506
mrsdizzie · Apr 4, 2019 · d05dbf7 · d05dbf7
1 parent d8802b1
commit d05dbf7
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/templates/repo/release/list.tmpl b/templates/repo/release/list.tmpl
@@ -77,7 +77,7 @@
 									{{if .Attachments}}
 										{{range $attachment := .Attachments}}
 										<li>
-											<a target="_blank" rel="noopener noreferrer" href="{{$.RepoLink}}/releases/download/{{$release.TagName}}/{{$attachment.Name}}">
+											<a target="_blank" rel="noopener noreferrer" href="{{$.RepoLink}}/releases/download/{{$release.TagName | PathEscape}}/{{$attachment.Name | PathEscape}}">
 												<strong><span class="ui image octicon octicon-package" title='{{$attachment.Name}}'></span> {{$attachment.Name}}</strong>
 												<span class="ui text grey right">{{$attachment.Size | FileSize}}</span>
 											</a>