-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removing babel #161
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #161 +/- ##
==========================================
- Coverage 98.59% 98.43% -0.16%
==========================================
Files 1 1
Lines 71 64 -7
==========================================
- Hits 70 63 -7
Misses 1 1
Continue to review full report at Codecov.
|
Hi @mrsteele |
It is! You got thoughts or feedback?!? |
I don't have any super useful feedback right up front. My own codebase has a few packages using babel 6 that cause conflicts with babel v7. Part of which lead me to your PR. So was pretty excited to see this PR in progress and wanted to get a feel for where you were with this one. To see if it's close or if there are specific things that prevented it from being merged. I'd need a bit of an upgrade on babel to be able to provide useful technical help. Of course not out of the question. |
This PR is essentially done. I was nervous to push the button because of the popularity of this, but also the worry of the impact of how much it would be supported on older versions of node |
I hear you on that. It does have quite a few users. Still supporting current users on the previous versions hmmm. If really wanting to support older versions of node going forward maybe even then a different PR that just does an upgrade to Babel 7 and save this one for later when the time is right. |
@emanualjade Just wanted to mention this plugin is now using babel 7. Hopefully that solves some of the problems you were facing. |
No description provided.