fix(cli): display stack trace on errors by default (dequelabs#555)

packages/cli/src/bin/cli.test.ts

@@ -282,15 +282,31 @@ describe('cli', () => {
   });
 
   describe('--show-errors', () => {
-    it('should log the time it takes to run', async () => {
+    it('should log the time it takes to run defaults to show errors', async () => {
       const result = await runCLI(
         `file://${SIMPLE_HTML_FILE}`,
-        '--show-errors'
+        '--include',
+        '#hazaar'
       );
-      assert.equal(result.exitCode, 0);
+      assert.equal(result.exitCode, 1);
       assert.include(
-        result.stdout,
-        'Violation of "marquee" with 1 occurrences!'
+        result.stderr,
+        'Error: JavascriptError: javascript error:'
+      );
+    });
+
+    it('do not show errors when passed false', async () => {
+      const result = await runCLI(
+        `file://${SIMPLE_HTML_FILE}`,
+        '--include',
+        '#hazaar',
+        '--show-errors',
+        'false'
+      );
+      assert.equal(result.exitCode, 1);
+      assert.include(
+        result.stderr,
+        'An error occurred while testing this page.'
       );
     });
   });

packages/cli/src/bin/cli.ts

@@ -63,7 +63,7 @@ program
     'Set how much time (seconds) axe has to run (default: 90)'
   )
   .option('--timer', 'Log the time it takes to run')
-  .option('--show-errors', 'Display the full error stack')
+  .option('--show-errors [boolean]', 'Display the full error stack', true)
   // TODO: Replace this with a reporter option, this required adding
   .option('--no-reporter', 'Turn the CLI reporter off')
   .option(

packages/cli/src/bin/index.ts

@@ -26,7 +26,6 @@ const cli = async (
     dir,
     exit,
     timer,
-    showErrors,
     reporter: noReporter,
     chromeOptions,
     verbose,
@@ -40,6 +39,8 @@ const cli = async (
     chromedriverPath
   } = args;
 
+  const showErrors = args.showErrors === true;
+
   const silentMode = !!stdout;
   args.axeSource = getAxeSource(args.axeSource);