Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: cargo deny fails for unapproved license #48

Closed
mrtryhard opened this issue May 4, 2024 · 2 comments
Closed

Bug: cargo deny fails for unapproved license #48

mrtryhard opened this issue May 4, 2024 · 2 comments
Assignees
@mrtryhard
Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Milestone
0.3.1 - Bugfixes

Comments

@mrtryhard
Copy link
Owner

Operating system: All
qt-ts-tools version: 0.3.0
Problem's description:
cargo deny check fails because some licenses are not approved: ISC, Apache 2.0 with llvm exception, etc.

Expected behavior / output:

  • cargo deny check should at most output warnings.

Sample problematic translation file

n/a

Sample expected / correct output file

n/a
@mrtryhard mrtryhard added bug Something isn't working documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file labels May 4, 2024
@mrtryhard mrtryhard added this to the 0.3.1 - Bugfixes milestone May 4, 2024
@mrtryhard
Copy link
Owner Author

ISC is OK
Apache 2.0 with LLVM EXCEPTION is also fine

mrtryhard added a commit that referenced this issue May 4, 2024
@mrtryhard
fixes #48: Fix warnings in cargo deny configuration.
7edf68b 
Also add cargo deny checks in CI.
Adds cargo clippy check.
mrtryhard added a commit that referenced this issue May 4, 2024
@mrtryhard
Merge pull request #51 from mrtryhard/bugfix/48-cargo-deny-check-license
b54e950 
fixes #48: Fix warnings in cargo deny configuration.
@mrtryhard mrtryhard self-assigned this May 4, 2024
@mrtryhard
Copy link
Owner Author

For some reasons couldn't be reproed, but the configuration warnings were fixed.

@mrtryhard mrtryhard mentioned this issue May 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrtryhard mrtryhard

Labels
bug Something isn't working dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation
Projects
None yet
Milestone
0.3.1 - Bugfixes
Development

No branches or pull requests
1 participant
@mrtryhard