Syntax error when using non-standard DB names

[mksplg]

When using a non standard DB name, e.g. test-db, a syntax error is thrown.

db_1  | Multiple database creation requested: test-db
db_1  |   Creating user and database 'test-db'
db_1  | 2017-12-15 09:11:35.898 UTC [66] ERROR:  syntax error at or near "-" at character 17
db_1  | 2017-12-15 09:11:35.898 UTC [66] STATEMENT:  CREATE USER test-db;
db_1  | ERROR:  syntax error at or near "-"
db_1  | LINE 1: CREATE USER test-db;

This could be avoided by using double quotes around the variables in the SQL statements.

[mrts]

Agreed. Would you perhaps like to send a pull request :)?

[mrts]

I'm sorry, but after further investigation I suggest that we don't do this - it forces everyone to use quotes throughout, see e.g. https://stackoverflow.com/a/6331658/258772. This is not a good thing.

What do you think?

[mksplg]

A quick test didn't show the problem described in the SO answer.

psql (10.1, server 9.6.1)
Type "help" for help.

postgres=# \l
                             List of databases
   Name    |  Owner   | Encoding | Collate | Ctype |   Access privileges
-----------+----------+----------+---------+-------+-----------------------
 postgres  | postgres | UTF8     | C       | C     | =Tc/postgres         +
           |          |          |         |       | postgres=CTc/postgres+
           |          |          |         |       | user=CTc/postgres
 template0 | postgres | UTF8     | C       | C     | =c/postgres          +
           |          |          |         |       | postgres=CTc/postgres
 template1 | postgres | UTF8     | C       | C     | =c/postgres          +
           |          |          |         |       | postgres=CTc/postgres
(3 rows)

postgres=# CREATE DATABASE "test";
CREATE DATABASE
postgres=# \l
                             List of databases
   Name    |  Owner   | Encoding | Collate | Ctype |   Access privileges
-----------+----------+----------+---------+-------+-----------------------
 postgres  | postgres | UTF8     | C       | C     | =Tc/postgres         +
           |          |          |         |       | postgres=CTc/postgres+
           |          |          |         |       | user=CTc/postgres
 template0 | postgres | UTF8     | C       | C     | =c/postgres          +
           |          |          |         |       | postgres=CTc/postgres
 template1 | postgres | UTF8     | C       | C     | =c/postgres          +
           |          |          |         |       | postgres=CTc/postgres
 test      | postgres | UTF8     | C       | C     |
(4 rows)

postgres=# ALTER DATABASE test RENAME TO test2;
ALTER DATABASE
postgres=# \l
                             List of databases
   Name    |  Owner   | Encoding | Collate | Ctype |   Access privileges
-----------+----------+----------+---------+-------+-----------------------
 postgres  | postgres | UTF8     | C       | C     | =Tc/postgres         +
           |          |          |         |       | postgres=CTc/postgres+
           |          |          |         |       | user=CTc/postgres
 template0 | postgres | UTF8     | C       | C     | =c/postgres          +
           |          |          |         |       | postgres=CTc/postgres
 template1 | postgres | UTF8     | C       | C     | =c/postgres          +
           |          |          |         |       | postgres=CTc/postgres
 test2     | postgres | UTF8     | C       | C     |
(4 rows)

postgres=#

psql (10.1, server 9.6.1)
Type "help" for help.

postgres=# CREATE TABLE A();
CREATE TABLE
postgres=# \dt
        List of relations
 Schema | Name | Type  |  Owner
--------+------+-------+----------
 public | a    | table | postgres
(1 row)

postgres=# SELECT * FROM A;
--
(0 rows)

postgres=# SELECT * FROM "A";
ERROR:  relation "A" does not exist
LINE 1: SELECT * FROM "A";
                      ^
postgres=# SELECT * FROM "a";
--
(0 rows)

postgres=# #

I think the problem is that postgresql converts names without quotes to lowercase, so using quotes might be unexpected for the user. I don't really know enough about postgres to say if this has further implications.

[mksplg]

Adding quotes around the names in docker-compose actually works for me, looks like they are passed to the script.

[...]
    environment:
      - POSTGRES_MULTIPLE_DATABASES="test-db-1","test-db-2"
[...]

[mrts]

Perfect, now you hit the mark 👍 - it's a documentation issue after all. I'll amend the readme accordingly.

[mrts]

And many thanks for the thorough tests, much appreciated!

[mrts]

Please review #7, do you agree this is sufficient?

[mrts]

Fixed with #7