Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE: Fix Godep revisions #13

Closed
wants to merge 1 commit into from

Conversation

runcom
Copy link
Contributor

@runcom runcom commented Jul 20, 2016

k8s commit 60894b9e4089dd5a854b2c71b6f7d7b1e7a6e9f3 wasn't in k8s git tree because I think @mrunalp imported them directly from a commit (that commit is from the PR but not in git tree)

runtime-spec commit 5c5867d534f48d4fb70ec2f9593a3a4ddc5b472c isn't on master but comes from @mrunalp $GOPATH while working on opencontainers/runtime-spec#518 (Godep sucks I know...)

the error you get when you godep restore:

# cd /home/amurdaca/src/github.com/kubernetes/kubernetes; git checkout 60894b9e4089dd5a854b2c71b6f7d7b1e7a6e9f3
fatal: reference is not a tree: 60894b9e4089dd5a854b2c71b6f7d7b1e7a6e9f3
godep: error restoring dep (github.com/kubernetes/kubernetes/pkg/kubelet/api/v1alpha1/runtime): exit status 128
# cd /home/amurdaca/src/github.com/opencontainers/runtime-spec; git checkout 5c5867d534f48d4fb70ec2f9593a3a4ddc5b472c
fatal: reference is not a tree: 5c5867d534f48d4fb70ec2f9593a3a4ddc5b472c
godep: error restoring dep (github.com/opencontainers/runtime-spec/specs-go): exit status 128
godep: Error restoring some deps. Aborting check.

Because those revisions comes from not origin branches.

Fixed this by checking-out the correct master branches and godep save again.
@mrunalp PTAL

Signed-off-by: Antonio Murdaca runcom@redhat.com

Signed-off-by: Antonio Murdaca <runcom@redhat.com>
@runcom runcom changed the title Fix Godep revisions DO NOT MERGE: Fix Godep revisions Jul 20, 2016
@runcom
Copy link
Contributor Author

runcom commented Jul 20, 2016

marking this as do not merge as I've imported this commit into #12

@mrunalp
Copy link
Owner

mrunalp commented Jul 20, 2016

Sounds good. We'll merge it alongwith #12

@runcom
Copy link
Contributor Author

runcom commented Jul 20, 2016

Closing then!

@runcom runcom closed this Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants