Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s commit 60894b9e4089dd5a854b2c71b6f7d7b1e7a6e9f3 wasn't in k8s git tree because I think @mrunalp imported them directly from a commit (that commit is from the PR but not in git tree)
runtime-spec commit 5c5867d534f48d4fb70ec2f9593a3a4ddc5b472c isn't on master but comes from @mrunalp $GOPATH while working on opencontainers/runtime-spec#518 (Godep sucks I know...)
the error you get when you
godep restore
:Because those revisions comes from not origin branches.
Fixed this by checking-out the correct master branches and godep save again.
@mrunalp PTAL
Signed-off-by: Antonio Murdaca runcom@redhat.com