generate: Drop devices and mounts #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since opencontainers/runtime-spec#164 (part of the v0.1.1 release [1]), Linux runtimes are required to supply these devices and mounts. Specifying them explicitly in the config should have no effect, and just makes the config longer than it needs to be. [1]: https://github.com/opencontainers/specs/blob/v0.1.1/config-linux.md#default-devices-and-file-systems Signed-off-by: W. Trevor King <wking@tremily.us>
Linux runtimes are not required to supply this [1,2]. We could supply it via ocitool, but I don't think its wise to try and define two standards (one in opencontainers/specs for what a runtime must supply, and another here with additional stuff), because I don't see a clear definition of something generally useful enough to go here but not in the spec. For example, hosts without CONFIG_POSIX_MQUEUE could be spec-compliant but unable to perform the mqueue mount I'm removing here. [1]: https://github.com/opencontainers/specs/blob/v0.1.1/config-linux.md#default-devices-and-file-systems [2]: opencontainers/runtime-spec#164 Signed-off-by: W. Trevor King <wking@tremily.us>
|
@wking I don't mind merging this but will wait for runc to work with this. |
|
On Mon, Dec 07, 2015 at 12:23:28PM -0800, Mrunal Patel wrote:
No problem, although we might want to wait until |
|
@mrunalp I don't think we should wait for runc to catchup to the spec. We are going to be out of sync no matter what. |
|
Replaced by opencontainers/runtime-tools#2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these are covered by the requirements that landed in
opencontainers/runtime-spec#164, and I don't think the additional mqueue
mount is worth the space between the spec requirements and the
ocitools-generated configs. More details in the commit messages.