Skip to content

Commit

Permalink
Ensure project compiles with Yarn 4+
Browse files Browse the repository at this point in the history
  • Loading branch information
mrxz committed Oct 22, 2024
1 parent bb91a23 commit e7de17e
Show file tree
Hide file tree
Showing 7 changed files with 9,832 additions and 7,271 deletions.
5 changes: 3 additions & 2 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"plugins": ["@typescript-eslint"],
"parser": "@typescript-eslint/parser",
"root": true,
"parserOptions": {
"project": "./tsconfig.json"
},
Expand All @@ -19,7 +20,7 @@
"curly": ["error", "multi-line"], // if statements without curly are evil
"no-console": ["error", { "allow": ["info", "warn", "error"] }], // do not leave console.log
"require-atomic-updates": ["off"], // the rule is kinda buggy
"@typescript-eslint/no-unnecessary-type-assertion": ["error"], // we don't need unnecessary type assertions
"@typescript-eslint/no-unnecessary-type-assertion": "error", // we don't need unnecessary type assertions
"@typescript-eslint/naming-convention": [
"error",
{
Expand Down Expand Up @@ -63,7 +64,7 @@
}
],
"@typescript-eslint/no-unused-vars": ["warn", { "args": "none" }], // we sometimes have to define unused arguments
"@typescript-eslint/no-explicit-any": ["off"], // Three.js sometimes forces us to deal with anys
"@typescript-eslint/no-explicit-any": "off", // Three.js sometimes forces us to deal with anys
"@typescript-eslint/no-non-null-assertion": ["off"] // Three.js sometimes forces us to deal with bangs
}
}
2 changes: 2 additions & 0 deletions .github/workflows/inspect.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ jobs:
uses: actions/setup-node@v4
with:
node-version-file: './.node-version'
- name: Install Latest Yarn
run: yarn set version 4.5.1
- name: Cache Deps
uses: actions/cache@v4
with:
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,5 @@
/packages/*/docs
/packages/*/lib
/packages/*/types
/tmp
/tmp
.yarn
2 changes: 2 additions & 0 deletions .yarnrc.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
nodeLinker: "node-modules"

1 change: 1 addition & 0 deletions packages/three-vrm-springbone/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@
},
"devDependencies": {
"@types/three": "^0.169.0",
"cross-env": "^7.0.3",
"three": "^0.169.0"
},
"peerDependencies": {
Expand Down
1 change: 1 addition & 0 deletions packages/three-vrm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@
},
"devDependencies": {
"@types/three": "^0.169.0",
"cross-env": "^7.0.3",
"three": "^0.169.0"
},
"peerDependencies": {
Expand Down
17,089 changes: 9,821 additions & 7,268 deletions yarn.lock

Large diffs are not rendered by default.

0 comments on commit e7de17e

Please sign in to comment.