Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.3.8 #2

Merged
merged 23 commits into from
Dec 28, 2020
Merged

0.3.8 #2

merged 23 commits into from
Dec 28, 2020

Conversation

ms7m
Copy link
Owner

@ms7m ms7m commented Dec 28, 2020

  • Support for getting, editing and deleting commands via Dispike
  • Support for registering commands.
  • Updated README.md
  • Updated type hints for different functions

⚠️ Warning ⚠️

Autocompletion for creating new models under DiscordCommand, CommandChoice, CommandOption, SubcommandOption, CommandTypes on VSCode is broken. (follow discussion here pydantic/pydantic#650, microsoft/python-language-server#1898). PyCharm appears to work using an external plugin.

@todo
Copy link

todo bot commented Dec 28, 2020

Create a self attribute for a Client for <Dispike> object

dispike/dispike/main.py

Lines 82 to 87 in 75ef751

# TODO: Create a self attribute for a Client for <Dispike> object
_send_request = self._registrator._client.get(
_url, headers=self._registrator.request_headers
)
if _send_request.status_code == 200:
return [IncomingApplicationCommand(**x) for x in _send_request.json()]


This comment was generated by todo based on a TODO comment in 75ef751 in #2. cc @ms7m.

@todo
Copy link

todo bot commented Dec 28, 2020

Add custom exceptions for Discord API failures.

dispike/dispike/main.py

Lines 89 to 94 in 75ef751

# TODO: Add custom exceptions for Discord API failures.
raise Exception(
f"Discord API returned an unknown error for getting commands: [{_send_request.status_code}] -> {_send_request.text}"
)
except Exception:
raise


This comment was generated by todo based on a TODO comment in 75ef751 in #2. cc @ms7m.

@todo
Copy link

todo bot commented Dec 28, 2020

Create a self attribute for a Client for <Dispike> object

dispike/dispike/main.py

Lines 82 to 87 in 7c80ef6

# TODO: Create a self attribute for a Client for <Dispike> object
_send_request = self._registrator._client.get(
_url, headers=self._registrator.request_headers
)
if _send_request.status_code == 200:
return [IncomingApplicationCommand(**x) for x in _send_request.json()]


This comment was generated by todo based on a TODO comment in 7c80ef6 in #2. cc @ms7m.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant