Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress logging output by default #7

Closed
AuHau opened this issue May 31, 2020 · 2 comments
Closed

Suppress logging output by default #7

AuHau opened this issue May 31, 2020 · 2 comments

Comments

@AuHau
Copy link

AuHau commented May 31, 2020

When I am sending notification I get bunch of logging output into the terminal. Since this is a library people might not be really interested in this logging by default. For example, I am using it in CLI application and there it is very distracting and not required.

Can you please by default turn it off? Maybe it could be turned on with a flag in options of the constructor? Or environmental variable? I logging will be used only in debugging scenario.
ms7m added a commit that referenced this issue Jun 1, 2020
@ms7m
add kwarg for disabling logging (#7)
c904265
@ms7m ms7m mentioned this issue Jun 1, 2020
Merged
@ms7m
Copy link
Owner

ms7m commented Jun 1, 2020

Thanks Adam,

v0.2.2 fixes this.

To re-enable logging

from notifypy import Notify

n = Notify(enable_logging=True)

n.send()

Cheers

@ms7m ms7m closed this as completed Jun 1, 2020
@AuHau
Copy link
Author

AuHau commented Jun 1, 2020

Sweet! Thanks again for such a prompt answer!

Good luck on your journey 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AuHau @ms7m