fix: branch name sanity check

msanguineti · Jul 15, 2019 · cd9fbca · cd9fbca
1 parent 0abf48b
commit cd9fbca
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/cmds/feature/start.ts b/src/cmds/feature/start.ts
@@ -18,7 +18,10 @@ export class StartFeature implements CommandModule {
   public handler = (argv: Arguments) => {
     const branchOff = argv.usedev ? argv.development : argv.main
 
-    if (isValidBranchName(argv.featureBranch)) {
+    if (
+      isValidBranchName(argv.featureBranch) &&
+      (branchOff ? isValidBranchName(branchOff) : true)
+    ) {
       exec(`git checkout -b ${argv.feature}/${argv.featureBranch} ${branchOff}`)
     }
   }

diff --git a/src/cmds/hotfix/start.ts b/src/cmds/hotfix/start.ts
@@ -11,8 +11,6 @@ import { exec } from 'shelljs'
 /* eslint-enable @typescript-eslint/no-unused-vars */
 import { Arguments, CommandModule } from 'yargs'
 
-// const git = simplegit()
-
 export class StartHotfix implements CommandModule {
   public command: string = 'start <hotfixName> <from>'