Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix featured section background size on android devices with api level 30 or below #101

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

darktiny
Copy link
Contributor

Screenshot_20230918_161213

@msasikanth
Copy link
Owner

Oh, good catch. Thanks for raising a PR. That particular variable is for image based aspect ratio and isn't for gradient based one. Please create a new variable that will change the aspect ratio for gradient background, I will get the other two values for different window sizes.

@darktiny
Copy link
Contributor Author

@msasikanth Updated

@msasikanth
Copy link
Owner

@msasikanth Updated

Please set these as values for the gradient background

when (LocalWindowSizeClass.current.widthSizeClass) {
  WindowWidthSizeClass.Compact -> 0.8f
  WindowWidthSizeClass.Medium -> 1.11f
  WindowWidthSizeClass.Expanded -> 2.3f
  else -> 0.8f
}

@darktiny
Copy link
Contributor Author

@msasikanth Updated

@msasikanth
Copy link
Owner

@msasikanth Updated

You updated the wrong values. We need to use these for the featuredGradientBackgroundAspectRatio variable that you created.

@msasikanth msasikanth changed the title Fix huge FeaturedSection gap on android devices with api level 30 or below Fix featured section background size on android devices with api level 30 or below Sep 20, 2023
@darktiny
Copy link
Contributor Author

@msasikanth Sorry for that, Updated

@msasikanth msasikanth merged commit 23f0f6b into msasikanth:main Sep 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants