This repository has been archived by the owner on Jan 16, 2024. It is now read-only.
Concurrency token (Timestamp) in constructor parameters #24
Labels
bug
Confirmed bug
Comments
|
You're right that the concurrency token property, while a required field, isn't something the user messes with. That's a bug. And it's now on the list. Looking forward to when you get a chance to fork and are able to submit pull requests ... you're finding some good stuff. Thanks! |
|
Fixed in v1.2.6.7. Thanks a million for the report! |
msawczyn
added a commit
that referenced
this issue
Sep 24, 2018
- An entity's concurrency token property is no longer a required parameter in its constructor (#24) - Simplified cascade delete settings in property editor for associations - Fixed bad code generation in EFCore for cascade delete overrides - Missing files when generating code for .NET Core projects fixed - Tightened up and swatted some bugs in INotifyPropertyChanged handling. Added documentation to doc site for this feature
msawczyn
added a commit
that referenced
this issue
Sep 24, 2018
- An entity's concurrency token property is no longer a required parameter in its constructor (#24) - Simplified cascade delete settings in property editor for associations - Fixed bad code generation in EFCore for cascade delete overrides (#22) - Missing files when generating code for .NET Core projects fixed - Tightened up and swatted some bugs in INotifyPropertyChanged handling. Added documentation to doc site for this feature (following up on #23) - Ensured multiline editing was available in property window for those properties that made sense
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current implementation of the EFDesigner.ttinclude includes the TimeStamp conccurency token into the parameters of the public constructor with required data and also into the paras of the static Create method.
If I'm not mistaken there is no reaand son why a user should set the conccurency token property and EF core is taking care of this. Therefore I think that the conccurency token property should be excluded from the methods mentioned above.
Remark:
I happpy to share my modified EFDesigner.ttinclude and EFCoreDesigner.ttinclude files, but I at least for now I cant make a pull request, since I just use local copies of these files in my project and have not (yet) forked the EFDesigner project.
The text was updated successfully, but these errors were encountered: