Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix build on macOS Ventura | gnu 2020 [-Wc++17-extensions] #170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stefanKuijers
Copy link

Since the node update from v18 to v19 mmmagic didn't compile anymore because missing C++ extensions. This merge request fixes that by changing the compiler and target platform.

Warning that it used to throw:

'static_assert' with no message is a C++17 extension [-Wc++17-extensions]

Error that is threw:

error: expected '(' for function-style cast or type construction

Please take a look and accept the merge request if you are happy with it.
Thanks in advance!

PS: I have not tested or it works on Mac if you OS is not up to date.

@Hikariii
Copy link

Hikariii commented Jun 2, 2023

Good luck getting this merged ;)
image

@stefanKuijers
Copy link
Author

Thanks! :D
I did see that before I submitted it.
Always hopeful you know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants