Fixed MacOSX compile issue #171
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this be merged? I'd really like to be able to use this with Node 20. |
|
It would be great if we could merge it, it would tremendously help me and my team as well. |
|
Waiting for this merge as well. This is breaking the install for my lib https://github.com/llm-tools/embedJs. Thank you. |
|
Since this appears to be unmaintained with a bunch of open PR's - I've forked the repo and will be applying this patch (among others) in my fork to hopefully fix the problem Edit: published @ https://www.npmjs.com/package/mmmagic2 |
notnikola1
added a commit
to notnikola1/mmmagic
that referenced
this pull request
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #169