Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Performance #71

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Better Performance #71

wants to merge 2 commits into from

Conversation

magicode
Copy link

11430.4 ops/sec
VS
2223.1 ops/sec

@mscdex
Copy link
Owner

mscdex commented Jan 18, 2016

Briefly looking over the changes it looks like the purpose of this is to add some sort of magic_set pool? Have you compared performance with a std::queue? Maybe a better solution might be to have a global pool (using a MPMC queue such as this) with some sensible upper bound on size?

@marcesengel
Copy link

I don't want to sound rude, but only looking at the numbers provided by @magicode it seems to be arguably faster than the current way - in case it would be even faster using std::queue, does that matter as long as nobody implements it?

I think that this should be merged (unless I am overlooking some bugs or bad code), as it seems to be around 5x faster than the current solution (looking at the provided benchmark) - regardless of wether or not it could be even faster, that still looks like a valuable improvement.

@ridakk
Copy link

ridakk commented Apr 29, 2018

+1

@mscdex mscdex force-pushed the master branch 2 times, most recently from 5421bc6 to 641e2ed Compare April 30, 2019 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants