-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invitation of making PR on MMSegmentation. #33
Comments
Hi @MengzhangLI, thanks for your interest in our work. I'd be happy to make our work available to as many as possible. Could you provide an exact design specification of what you would need in this PR? For example, the API design for training, dataset loaders, inference, taxonomy support, CPU/GPU support, and model storage? |
Hi @MengzhangLI, haven't heard back from you, so closing this issue. If you are able to put a design doc together with the implementation specification, I'm happy to chat more. Feel free to re-open the issue if you'd like to discuss more. |
Hi, @johnwlambert Sorry for late reply because first week of October in mainland China is holiday. Comparing with model itself, it is easier to integrate dataset into MMSegmentation framework. From our repo there are many widely used datasets. If it is official supported, we usually add its python file into Let us keep in touch and hope we could work together to make more people use your dataset and model! Best, |
For model, it is a little bit complicated. I would spend some time reading your answer mseg-dataset/mseg-api#34 to know more things.
For example, this is my re-implementation pr of BiSeNetV2, to add this model, I only do three things: (1) add model in ./mmseg/models/, (2) add config files in ./configs/ which MMSegmentation would use this file to build model, (3) add unit test file to control my pr quality during coding. I think we only need to add model and dataset, don't need to care about dataloader and someother things if we could provide images and their pixel-wise ground truth. Best, |
Hey, here!
I am the member of OpenMMLab. This dataset and its related code/method are very valuable for segmentation. We hope we could introduce more people know this method and use dataset.
Would you like to make a new pr on MMSegmentation with us? We could work together to support this model and dataset effectively!
Best,
The text was updated successfully, but these errors were encountered: