Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support coco stuff-10k/164k #625

Merged
merged 49 commits into from
Sep 22, 2021
Merged

Conversation

DerrickWang005
Copy link
Contributor

@DerrickWang005 DerrickWang005 commented Jun 22, 2021

  1. Conversion scripts of Coco Stuff-10k/164k.
  2. Guideline of the dataset preparation.
  3. Dataset file of Coco Stuff-10k/164k.
  4. Four configurations of PSPNet on Coco Stuff-10k/164k.

@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #625 (2ede4a4) into master (4d8229c) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

❗ Current head 2ede4a4 differs from pull request most recent head 186161e. Consider uploading reports for the commit 186161e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #625      +/-   ##
==========================================
- Coverage   89.05%   89.05%   -0.01%     
==========================================
  Files         111      112       +1     
  Lines        6051     6060       +9     
  Branches      969      970       +1     
==========================================
+ Hits         5389     5397       +8     
- Misses        467      468       +1     
  Partials      195      195              
Flag Coverage Δ
unittests 89.05% <88.88%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmseg/datasets/coco_stuff.py 87.50% <87.50%> (ø)
mmseg/datasets/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8229c...186161e. Read the comment docs.

@Junjun2016
Copy link
Collaborator

Hi @DerrickWang005
Thanks for your nice PR!

@DerrickWang005
Copy link
Contributor Author

You are welcome. :)

docs/dataset_prepare.md Outdated Show resolved Hide resolved
docs/dataset_prepare.md Outdated Show resolved Hide resolved
Comment on lines 217 to 220
if args.out_dir is None:
out_mask_dir = osp.join(coco_path, 'masks')
else:
out_mask_dir = args.out_dir
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor it according to coco stuff 10k

@Junjun2016
Copy link
Collaborator

Hi @DerrickWang005
Please fix the lint.

@Junjun2016
Copy link
Collaborator

COCO-Stuff 164k results:
image

@Junjun2016
Copy link
Collaborator

COCO-Stuff 10k results:
image

@openmmlab-bot
Copy link
Collaborator

Task linked: CU-1f0zypv coco-stuff dataset

@xvjiarui
Copy link
Collaborator

Add coco stuff in README.md

@Junjun2016
Copy link
Collaborator

Update supported datasets in README.md.

@shijianjian
Copy link

Can this be merged in the near future?

@Junjun2016
Copy link
Collaborator

Can this be merged in the near future?

This month.

[192, 64, 128],
[64, 192, 96],
[64, 160, 64],
[64, 64, 0],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
[64, 64, 0],
[64, 64, 0]

@Junjun2016 Junjun2016 merged commit 62f70eb into open-mmlab:master Sep 22, 2021
bowenroom pushed a commit to bowenroom/mmsegmentation that referenced this pull request Feb 25, 2022
* support coco stuff-10k/164k

* update docs

* fix docs

* update docs

* fix import lints

* Update docs/dataset_prepare.md

* Update docs/dataset_prepare.md

* Update tools/convert_datasets/coco_stuff164k.py

* Update tools/convert_datasets/coco_stuff10k.py

* Update tools/convert_datasets/coco_stuff10k.py

* Update tools/convert_datasets/coco_stuff10k.py

* Update tools/convert_datasets/coco_stuff10k.py

* Update coco_stuff.py

fix the description of the dataset

* Update dataset_prepare.md

fix the doc tree of coco stuff 10k

* Update coco_stuff10k.py

fix img_dir

* Update coco_stuff.py

fix descriptions

* Update coco_stuff164k.py

fix out_dir

* Update coco_stuff10k.py

fix save file name

* Update coco_stuff.py

fix seg_map_suffix

* Update dataset_prepare.md

fix -p

* Update dataset_prepare.md

fix doc tree

* modify coco stuff convertor

* Remove redundant code

* fix 164k convert bug

* remove redundant comment

* add deeplabv3 configs and more iterations

* replace shutil.move with shtil.copyfile

* Update deeplabv3_r50-d8_512x512_4x4_80k_coco_stuff10k.py

fix wrong config

* Update deeplabv3_r101-d8_512x512_4x4_80k_coco_stuff164k.py

fix wrong config

* fix wrong configs

* fix wrong configs

* fix wrong path for coco stuff 10k

* fix convert bugs

* fix seg_filename bug

* when nproc=0, use track progress

* rename configs: coco_stuff --> coco-stuff

* add coco-stuff 10k and 164k to README.md

* update configs

* add deeplabv3 benchmark

* add pspnet benchmark

* remove redundant comma

Co-authored-by: Junjun2016 <hejunjun@sjtu.edu.cn>
@OpenMMLab-Coodinator
Copy link

Hi @DerrickWang005 !First of all, we want to express our gratitude for your significant PR in this project. Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.

We would also like to invite you to join our Special Interest Group (SIG) private channel on Discord, where you can share your experiences, ideas, and build connections with like-minded peers. To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. Look forward to seeing you there! Join us :https://discord.gg/UjgXkPWNqA

If you have WeChat account,welcome to join our community on WeChat. You can add our assistant :openmmlabwx. Please add "mmsig + Github ID" as a remark when adding friends:)
Thank you again for your contribution❤

sibozhang pushed a commit to sibozhang/mmsegmentation that referenced this pull request Mar 22, 2024
* [Improvement] Support non-sparse(one-hot like) label for CrossEntropyLoss

* fix

* update changelog

* detect loss from the shape of label

* update docs

* fix unittest, use almost equal instead of equal

* rename `non-sparse label` to `soft label`

* fix lint

* fix test

* rename sparse to hard, add assert for kwargs

* update docs

* update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants