Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encountered an endless loop for some text #43

Closed
lauvil opened this issue Jan 27, 2022 · 1 comment · Fixed by #45
Closed

Encountered an endless loop for some text #43

lauvil opened this issue Jan 27, 2022 · 1 comment · Fixed by #45

Comments

@lauvil
Copy link

lauvil commented Jan 27, 2022

There is a "while True" loop in rules.py (line 396) and I have some text where this enters an endless loop. The text is not pretty but it is parsing.

You might have other ways of solving this, but I found that adding the following code before the assignment of referring_or_governor to its head got me out of the loop.

if referring_or_governor == referring_or_governor.head:
break

@richardpaulhudson
Copy link
Collaborator

Thanks, that's definitely a safer way of performing the check. I've updated the code accordingly.

michel-ds added a commit to Guardian-Coreference-Project/coreferee that referenced this issue Jan 24, 2023
Some files loaded by the `LitBankANNLoader` get stuck in an endless loop.
This is probably due to the format rather than the loader itself given the fix is to the rule set.
This patch fixes it. More details here: msg-systems#43
michel-ds added a commit to Guardian-Coreference-Project/coreferee that referenced this issue Jan 25, 2023
Some files loaded by the `LitBankANNLoader` get stuck in an infinte loop.
This is probably due to the format rather than the loader itself given the fix is to the rule set.
This patch fixes it. More details here: msg-systems#43

(cherry picked from commit ff897d6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants