Install version/config files under CMAKE_INSTALL_LIBDIR #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to the c_master/cpp_master split, this is where the files were installed (c.f., https://github.com/msgpack/msgpack-c/blob/6e7deb809120881634b3ca895e66b2a946084f34/CMakeLists.txt#L454) but this was changed to use "lib/" directly when updating the C++-only packaging. Re-instate the use of CMAKE_INSTALL_LIBDIR so the user can control where they are installed and they follow the typical convention for location.
Codecov Report
@@ Coverage Diff @@
## cpp_master #1003 +/- ##
===========================================
Coverage 85.56% 85.56%
===========================================
Files 79 79
Lines 5009 5009
===========================================
Hits 4286 4286
Misses 723 723 |
jamessan
force-pushed
the
config-installdir
branch
from
d9440ad to
b4d800e
Compare
|
Thanks you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to the c_master/cpp_master split, this is where the files were installed (c.f.,
msgpack-c/CMakeLists.txt
Line 454 in 6e7deb8
Re-instate the use of CMAKE_INSTALL_LIBDIR so the user can control where they are installed and they follow the typical convention for location.