Explicitly specify the project is a C project if tests aren't used. #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake assumes the default project uses both C and C++, and therefore will fail if both a C and a C++ compiler isn't found. This essentially blocks pure C projects from using msgpack-c if they also don't have a C++ compiler. Just specifying that the project is "C" isn't possible though, as the test themselves use C++. The workaround here is that we specify the project needs both a C and C++ compiler if tests are used, but only a C compiler if the tests aren't used.
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## c_master #1055 +/- ##
=========================================
Coverage 55.45% 55.45%
=========================================
Files 8 8
Lines 1044 1044
=========================================
Hits 579 579
Misses 465 465 |
|
Thanks! LGTM. |
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 25, 2023
msgpack is written in c, so only enforce a c compiler upstream: msgpack/msgpack-c#1055 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
1 task
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 25, 2023
msgpack is written in c, so only enforce a c compiler upstream: msgpack/msgpack-c#1055 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 26, 2023
msgpack is written in c, so only enforce a c compiler upstream: msgpack/msgpack-c#1055 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 27, 2023
msgpack is written in c, so only enforce a c compiler upstream: msgpack/msgpack-c#1055 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 29, 2023
msgpack is written in c, so only enforce a c compiler upstream: msgpack/msgpack-c#1055 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
Apr 29, 2023
msgpack is written in c, so only enforce a c compiler upstream: msgpack/msgpack-c#1055 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
ThomasDevoogdt
added a commit
to ThomasDevoogdt/fluent-bit
that referenced
this pull request
May 4, 2023
msgpack is written in c, so only enforce a c compiler upstream: msgpack/msgpack-c#1055 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
leonardo-albertovich
pushed a commit
to fluent/fluent-bit
that referenced
this pull request
May 8, 2023
msgpack is written in c, so only enforce a c compiler upstream: msgpack/msgpack-c#1055 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
andreswebs
pushed a commit
to andreswebs/fluent-bit
that referenced
this pull request
May 9, 2023
msgpack is written in c, so only enforce a c compiler upstream: msgpack/msgpack-c#1055 Signed-off-by: Thomas Devoogdt <thomas.devoogdt@barco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake assumes the default project uses both C and C++, and therefore will fail if both a C and a C++ compiler isn't found. This essentially blocks pure C projects from using msgpack-c if their users also don't have a C++ compiler.
Just specifying that the project is "C" isn't possible though, as the test themselves use C++. The workaround here is that we specify the project needs both a C and C++ compiler if tests are used, but only a C compiler if the tests aren't used.