-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for std::variant
#1075
Conversation
as
and pack
for std::variant
std::variant
@redboltz I'm having a bit of problem implementing |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## cpp_master #1075 +/- ##
==============================================
+ Coverage 85.63% 85.74% +0.11%
==============================================
Files 79 80 +1
Lines 5040 5073 +33
==============================================
+ Hits 4316 4350 +34
+ Misses 724 723 -1 |
In the case of msgpack-c/include/msgpack/v1/adaptor/cpp17/optional.hpp Lines 67 to 81 in ac062e2
Hence, this |
There are some of coding style fix request. I will add the comment inline later. Maybe we need to communicate several times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use 4 whitespaces indent.
I pointed out one case for each request. Please fix other same parts.
@redboltz could you please have a look again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've checked updated one.
Merged. Thank you! |
No description provided.