link lib32z1-dev when building 32-bit library #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## cpp_master #892 +/- ##
===========================================
Coverage 86.51% 86.51%
===========================================
Files 72 72
Lines 5071 5071
===========================================
Hits 4387 4387
Misses 684 684 |
|
Looks good to me. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building 32-bit libraries, cmake cannot find
ZLIBeven iflib32z1-devis installed.It can be fixed by passing the installation path of 32-bit zlib to
ZLIB_LIBRARY.https://github.com/msgpack/msgpack-c/runs/820783777?check_suite_focus=true